Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Host Transport Node #973

Merged
merged 2 commits into from
Oct 4, 2023
Merged

Implement Host Transport Node #973

merged 2 commits into from
Oct 4, 2023

Conversation

GraysonWu
Copy link
Collaborator

No description provided.

@GraysonWu GraysonWu force-pushed the host-tn branch 2 times, most recently from a048ea5 to 488baf8 Compare September 19, 2023 23:32
@GraysonWu GraysonWu changed the title [WIP]Implement Host Transport Node Implement Host Transport Node Sep 19, 2023
@GraysonWu
Copy link
Collaborator Author

@ksamoray let me know if you are modifying functions getHostSwitchSpecFromSchema and getHostSwitchSpecFromSchema to make them suitable for referring obj with both id or path. I could make the appropriate changes to this PR. Thanks!

@ksamoray
Copy link
Collaborator

@ksamoray let me know if you are modifying functions getHostSwitchSpecFromSchema and getHostSwitchSpecFromSchema to make them suitable for referring obj with both id or path. I could make the appropriate changes to this PR. Thanks!

Finally I've opted to use general naming (PR #974) instead of having a parameterized signature, as having different suffixes for attributes would require different descriptions as well for policy and MP. So methods above will remain as they are (but documentation for policy_host_transport_node will change though).

@GraysonWu GraysonWu force-pushed the host-tn branch 2 times, most recently from 68aaf39 to 519d413 Compare September 25, 2023 05:33
annakhm
annakhm reviewed Sep 25, 2023
View reviewed changes
nsxt/resource_nsxt_policy_host_transport_node.go
Computed: true,
},
"discovered_node_id": {
Type: schema.TypeString,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be ForceNew?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it can be updated in place.

@GraysonWu
Address comments
c1eab7e 
Signed-off-by: graysonwu <[email protected]>
@salv-orlando
Copy link
Member

Merging the PR as Grayson won't be able to do that this week.

@salv-orlando salv-orlando merged commit d7e88df into vmware:master Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annakhm annakhm annakhm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@GraysonWu @ksamoray @salv-orlando @annakhm