Fix rule order bug #967
Merged
Fix rule order bug #967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NSX can not guarantee rule order unless sequence_number is provided, or `revise` API is called. This change auto-assigns sequence number to all rules in list, for which it was not provided by the user. It takes care of provider upgrade by making sure rules without assigned sequence number are updated even if terraform does not detect a change in them. Signed-off-by: Anna Khmelnitsky <[email protected]>
|
/test-all |
ksamoray
approved these changes
Sep 14, 2023
| @@ -469,6 +470,11 @@ func getPolicyRulesFromSchema(d *schema.ResourceData) []model.Rule { | |||
| } | |||
|
|
|||
| resourceType := "Rule" | |||
| if sequenceNumber == 0 { | |||
| sequenceNumber = lastSequence + 1 | |||
There was a problem hiding this comment.
Would it make sense to set sequence numbers with some gap between them? e.g 10, 20... etc so later a rule can be inserted between without recreating the whole list?
There was a problem hiding this comment.
From terraform perspective the list is ordered, which means if rule 3.5 is inserted between rule 3 and rule 4, this will result in diff for rule 4, and a new rule 5. As a result, we will update all rules starting from the inserted rule, hence we don't need to bother about gaps in sequence numbers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NSX can not guarantee rule order unless sequence_number is provided, or
reviseAPI is called.This change auto-assigns sequence number to all rules in list, for which it was not provided by the user.
It takes care of provider upgrade by making sure rules without assigned sequence number are updated even if terraform does not detect a change in them.