Update nsxt_nat_rule with firewall_match #950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksamoray
force-pushed
the
nsxt_nat_rule_nat_pass
branch
from
7fcfaf9 to
c8dc410
Compare
annakhm
reviewed
Aug 26, 2023
| @@ -245,41 +239,43 @@ func resourceNsxtNatRuleUpdate(d *schema.ResourceData, m interface{}) error { | |||
| //match_service := d.Get("match_service").(*NsServiceElement) | |||
| matchSourceNetwork := d.Get("match_source_network").(string) | |||
| natPass := d.Get("nat_pass").(bool) | |||
| firewallMatch := model.NatRule_FIREWALL_MATCH_MATCH_INTERNAL_ADDRESS | |||
There was a problem hiding this comment.
do we know what version this was added in?
There was a problem hiding this comment.
nat_pass was removed at 4.0.0
firewall_match exists in 2.4 - it seemed old enough so I didn't check earlier versions...
There was a problem hiding this comment.
Maybe I should keep the code which uses the old API for pre-4.0.0 environments?
There was a problem hiding this comment.
I think current code should be good, I would run the test against 3.0.0 to be sure
firewall_match attribute replace nat_pass in nsxt_nat_rule resource. Signed-off-by: Kobi Samoray <[email protected]>
ksamoray
force-pushed
the
nsxt_nat_rule_nat_pass
branch
from
c8dc410 to
f7dff16
Compare
annakhm
approved these changes
Aug 29, 2023
|
/test-all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
firewall_match attribute replace nat_pass in nsxt_nat_rule resource.
Fixes: #945