Support on-demand connection init in the provider #948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the new `on_demand_connection` provider flag is set to true, provider will not verify connection and pull NSX version on provider startup. Instead, those operations will be done for each provider instance when terraform objects are evaluated. This setting is useful when NSX appliance is being deployed via same apply process, and not yet responsive when the provider is initialized. This setting is not supported for VMC and not compatible with deprecated objects implemented via the old SDK. It is also temporarily incompatible with license feature (this will be fixed in follow up PR) Signed-off-by: Anna Khmelnitsky <[email protected]>
|
/test-all |
|
@annakhm should we run a test cycle (e.g sanity) with this turned on? |
ksamoray
approved these changes
Aug 22, 2023
|
/test-all |
wsquan171
reviewed
Aug 22, 2023
| clientAuthCertFile := d.Get("client_auth_cert_file").(string) | ||
| clientAuthKeyFile := d.Get("client_auth_key_file").(string) | ||
| clientAuthCert := d.Get("client_auth_cert").(string) | ||
| clientAuthKey := d.Get("client_auth_key").(string) | ||
| vmcToken := d.Get("vmc_token").(string) | ||
| vmcAuthMode := d.Get("vmc_auth_mode").(string) | ||
|
|
||
| if onDemandConn { |
There was a problem hiding this comment.
Does it make more sense if we make vmc params taking precedence over this on_demand_connection, in that if vmc tokens / mode is set, on_demand_connection is ignored and turned off?
There was a problem hiding this comment.
I think its preferrable that user is aware the setting is not applicable, and corrects the configuration
wsquan171
approved these changes
Aug 22, 2023
I ran the tests locally. Indeed we should add an option to pass env variables to CI. |
|
/test-all |
1 similar comment
|
/test-all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the new
on_demand_connectionprovider flag is set to true, provider will not verify connection and pull NSX version on provider startup. Instead, those operations will be done for each provider instance when terraform objects are evaluated.This setting is useful when NSX appliance is being deployed via same apply process, and not yet responsive when the provider is initialized. This setting is not supported for VMC and not compatible with deprecated objects implemented via the old SDK. It is also temporarily incompatible with license feature (this will be fixed in follow up PR)