-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for configuring cluster virtual IP #938
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2ez4szliu
force-pushed
the
ha-vip
branch
2 times, most recently
from
August 30, 2023 04:31
d46b2e1
to
7a6f2b5
Compare
2ez4szliu
changed the title
[WIP] Add support for configuring cluster virtual IP
Add support for configuring cluster virtual IP
Aug 30, 2023
annakhm
reviewed
Sep 6, 2023
annakhm
reviewed
Sep 6, 2023
annakhm
reviewed
Sep 6, 2023
annakhm
reviewed
Sep 6, 2023
annakhm
reviewed
Sep 6, 2023
annakhm
reviewed
Sep 6, 2023
2ez4szliu
force-pushed
the
ha-vip
branch
2 times, most recently
from
September 6, 2023 09:09
2fae415
to
f5c0f82
Compare
annakhm
approved these changes
Sep 15, 2023
@2ez4szliu, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
Implement cluster virtual IP resource to configure Ipv4 and Ipv6 virtual IP of NSX cluster. Signed-off-by: Shizhao Liu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An implementation for resource nsxt_cluster_virtual_ip to configure NSXT cluster virtual IPv4 and IPv6 address.
The virtual IP property can be part of nsxt_manager_cluster resource or an independent resource like in this PR, if we decide to implement it as part of nsxt_manage_cluster resource we can still use this PR as a reference.