Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support type attribute on T1 for VMC #909

Merged
merged 3 commits into from
Jun 30, 2023
Merged

Support type attribute on T1 for VMC #909

merged 3 commits into from
Jun 30, 2023

Conversation

annakhm
Copy link
Collaborator

@annakhm annakhm commented Jun 20, 2023

This attribute helps auto-configure route advertisements. In addition, support DR only mode for ha_mode setting.

@annakhm
Support type attribute on T1 for VMC
024ad7b 
This attribute helps auto-configure route advertisements.
In addition, support `DR only` mode for `ha_mode` setting.

Signed-off-by: Anna Khmelnitsky <[email protected]>
@annakhm
Copy link
Collaborator Author

annakhm commented Jun 20, 2023

/test-all

ksamoray
ksamoray approved these changes Jun 20, 2023
View reviewed changes
Copy link
Collaborator

@ksamoray ksamoray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vmwclabot
Copy link
Member

@annakhm, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@vmwclabot vmwclabot added the dco-required DCO Required label Jun 21, 2023
@vmwclabot
Copy link
Member

@annakhm, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@annakhm
Copy link
Collaborator Author

annakhm commented Jun 21, 2023

/test-all

@annakhm
Add doc clarification for T1 route adv types
46149df 
In addition, fix linter issues

Signed-off-by: Anna Khmelnitsky <[email protected]>
@vmwclabot
Copy link
Member

@annakhm, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@annakhm
Copy link
Collaborator Author

annakhm commented Jun 26, 2023

/test-all

@annakhm annakhm requested a review from ksamoray June 29, 2023 17:17
@annakhm annakhm merged commit 372a978 into master Jun 30, 2023
@annakhm annakhm deleted the t1-type branch February 5, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ksamoray ksamoray ksamoray approved these changes

Assignees
No one assigned
Labels
dco-required DCO Required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@annakhm @vmwclabot @ksamoray