Implement multi-tenancy support for relevant resources #895
Conversation
nsxt/utils.go
Outdated
| @@ -662,3 +662,25 @@ func handlePagination(lister func(*paginationInfo) error) (int64, error) { | |||
|
|
|||
| return total, nil | |||
| } | |||
|
|
|||
| func getContextSchema(forceNew bool) *schema.Schema { | |||
There was a problem hiding this comment.
When do we expect forceNew to be false?
Since context triggers object path change, seems to me ForceNew should always be defined
There was a problem hiding this comment.
Indeed. Thanks :)
There was a problem hiding this comment.
I'm guessing that the whole context - no matter what we'll add to it in the future, should be ForceNew as well.
ksamoray
force-pushed
the
api-wrapper
branch
7 times, most recently
from
1d1fa0f to
561c60b
Compare
|
/test-all |
ksamoray
force-pushed
the
api-wrapper
branch
6 times, most recently
from
26e5ce6 to
45c086f
Compare
|
/test-all |
ksamoray
force-pushed
the
api-wrapper
branch
14 times, most recently
from
90c9528 to
24f7a22
Compare
| d.Set("display_name", obj.DisplayName) | ||
| d.Set("description", obj.Description) | ||
| d.Set("path", obj.Path) | ||
| err := resourceNsxtPolicyTier1GatewayReadEdgeCluster(d, connector) |
There was a problem hiding this comment.
looks like edge cluster would not be set for local manager?
nsxt/policy_search.go
Outdated
| var cursor *string | ||
| total := 0 | ||
|
|
||
| // Make sure global objects are not found (path needs to start with infra) |
There was a problem hiding this comment.
this comment is not relevant here
| if gwID == "" { | ||
| // infra segment | ||
| client := segments.NewDhcpStaticBindingConfigsClient(connector) | ||
| if context.ClientType == utl.Global || gwID == "" { |
There was a problem hiding this comment.
fixed segments might be supported on GM now. I suggest not to change the logic in this PR but lets check this later (it would simplify the code to only look at GW present in this condition)
There was a problem hiding this comment.
OK. So should we open an issue to track this?
ksamoray
force-pushed
the
api-wrapper
branch
4 times, most recently
from
11a99b6 to
3481f4b
Compare
|
/test-all |
ksamoray
force-pushed
the
api-wrapper
branch
2 times, most recently
from
335e5fe to
1106dfc
Compare
| type: Multitenancy | ||
| model_name: PolicyContextProfile | ||
| obj_name: ContextProfile | ||
| var_name: policyContextProfileParam |
There was a problem hiding this comment.
Could you please explain the purpose of var_name? Can it be unified across all resources?
There was a problem hiding this comment.
Schema is explained at the top of the file. Specifically, var_name explained here
| return nil, err[0] | ||
| } | ||
|
|
||
| gmObj, err := converter.ConvertToGolang(dataValue, destType) |
There was a problem hiding this comment.
This is not specific to gm (global manager). Perhaps convertedObj?
|
I wonder if enforcement points relevant for /orgs? We have functions like |
|
|
ksamoray
force-pushed
the
api-wrapper
branch
4 times, most recently
from
7934a6f to
2295333
Compare
|
We would also need to craft a documentation guide for multitenancy use case, but this can be added in follow up |
ksamoray
force-pushed
the
api-wrapper
branch
3 times, most recently
from
28e0c6d to
16d0498
Compare
|
/test-all |
Signed-off-by: Kobi Samoray <[email protected]>
|
/test-all |
Some of the resource have been added support to multi-tenancy.
Support is implemented using a generated API wrapper, which abstracts the calls to the various NSX APIs (local manager/global manager/multi tenancy).