Fix issue when creating IPSecVpnSession with Compliance suite #891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test-all |
annakhm
reviewed
May 15, 2023
| @@ -175,6 +204,47 @@ func TestAccResourceNsxtPolicyIPSecVpnSessionRouteBased_basic(t *testing.T) { | |||
| }) | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
lets follow naming convention here - withComplianceSuite
annakhm
reviewed
May 15, 2023
| @@ -273,6 +343,49 @@ func TestAccResourceNsxtPolicyIPSecVpnSessionPolicyBased_basic(t *testing.T) { | |||
| }) | |||
| } | |||
|
|
|||
| func TestAccResourceNsxtPolicyIPSecVpnSessionPolicyBased_with_compliance_suite(t *testing.T) { | |||
annakhm
reviewed
May 15, 2023
| @@ -485,6 +598,7 @@ func testAccNSXPolicyIPSecVpnSessionImporterGetID(s *terraform.State) (string, e | |||
| } | |||
|
|
|||
| func testAccNsxtPolicyIPSecVpnSessionPreConditionTemplate(isT0 bool) string { | |||
There was a problem hiding this comment.
Tests using certificate should only run if testAccEnvDefined(t, "NSXT_TEST_CERTIFICATE_NAME"), otherwise looks like certificate data source will fail
|
/test-all |
Change tunnel_profile_path to use the computedPolicyPath so that IPSecVpnSession with compliance suite can be configured correctly. The MR also made enhancement to the docs. Signed-off-by: Shizhao Liu <[email protected]>
|
/test-all |
annakhm
approved these changes
May 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change tunnel_profile_path to use the computedPolicyPath so that IPSecVpnSession with compliance suite can be configured correctly.
The MR also made enhancement to the docs.