Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Segment security profile resource #878

Merged
merged 4 commits into from
May 1, 2023
Merged

Segment security profile resource #878

merged 4 commits into from
May 1, 2023

Conversation

annakhm
Copy link
Collaborator

@annakhm annakhm commented Apr 25, 2023

No description provided.

annakhm added 2 commits April 25, 2023 23:39
Signed-off-by: Anna Khmelnitsky <[email protected]>
@annakhm
Copy link
Collaborator Author

annakhm commented Apr 26, 2023

/test-all

@annakhm annakhm linked an issue Apr 27, 2023 that may be closed by this pull request
@vmwclabot
Copy link
Member

@annakhm, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@vmwclabot vmwclabot added the dco-required DCO Required label Apr 27, 2023
@annakhm
Copy link
Collaborator Author

annakhm commented Apr 27, 2023

/test-all

@annakhm annakhm requested review from ksamoray and 2ez4szliu April 27, 2023 17:13
Signed-off-by: Anna Khmelnitsky <[email protected]>
@vmwclabot
Copy link
Member

@annakhm, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

Optional: true,
Default: true,
},
"non_ip_traffic_block_enabled": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aren't we usually adding description to resource attributes?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file was generated by policygen, and descriptions in spec are often too long to appear here in the code. We do have them in documentation. I'm not sure description in the code has any practical purpose.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. I wonder how much the provider image will shrink if we remove all these strings :)

Copy link
Collaborator

@ksamoray ksamoray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@annakhm annakhm merged commit f5da148 into master May 1, 2023
@annakhm annakhm deleted the segment-security branch May 1, 2023 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-required DCO Required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for segment profiles
3 participants