-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add filtering options to vms data source #869
Conversation
/test-all |
@@ -31,6 +32,8 @@ resource "nsxt_policy_vm_tags" "test" { | |||
## Argument Reference | |||
|
|||
* `value_tupe` - (Optional) Type of VM ID the user is interested in. Possible values are `bios_id`, `external_id`, `instance_id`. Default is `bios_id`. | |||
* `state` - (Optional) Filter results by power state of the machine. | |||
* `os` - (Optional) Filter results by operating system of the machine. The match is case insensitive and prefix-based. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this os or guest_os?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, fixed
@@ -15,6 +15,7 @@ This data source is applicable to NSX Policy Manager and VMC. | |||
|
|||
```hcl | |||
data "nsxt_policy_vms" "all" { | |||
state = "running" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need to also add guest_os to the example template here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added that as well
VMs data source map can now be filtered by power state and operation system. Signed-off-by: Anna Khmelnitsky <[email protected]>
/test-all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
VMs data source map can now be filtered by power state and operation system.