Add ha_mode attribute to T1 gateway #856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
model.Tier1_HA_MODE_ACTIVE constant requires vSphere SDK upgrade |
annakhm
reviewed
Mar 27, 2023
| @@ -397,6 +409,7 @@ func policyTier1GatewayResourceToInfraStruct(d *schema.ResourceData, connector * | |||
| RouteAdvertisementRules: routeAdvertisementRules, | |||
| Ipv6ProfilePaths: ipv6ProfilePaths, | |||
| ResourceType: &t1Type, | |||
| HaMode: &haMode, | |||
There was a problem hiding this comment.
I think this should require NSX version check (specifying this value in early versions would likely lead to an error)
There was a problem hiding this comment.
For NSX < 4.0.0 this would cause Error: Failed to create Tier1: Json de-serialization error: property ha_mode is unrecognized. (code 287)
There was a problem hiding this comment.
NSX 3.2.0 has ha_mode attribute but no ACTIVE_ACTIVE option. I should add a condition for 3.1.3 and below
ksamoray
force-pushed
the
t1_ha_mode
branch
3 times, most recently
from
7eae58c to
6953aef
Compare
ksamoray
force-pushed
the
t1_ha_mode
branch
4 times, most recently
from
faa43cc to
c8750d8
Compare
|
/test-all |
ksamoray
force-pushed
the
t1_ha_mode
branch
2 times, most recently
from
d448124 to
d65c5cc
Compare
Fixes: vmware#852 Signed-off-by: Kobi Samoray <[email protected]>
|
/test-all |
annakhm
approved these changes
Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #852