Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix VPN data sources for newer NSX version #837

Merged
merged 1 commit into from
Feb 21, 2023
Merged

Fix VPN data sources for newer NSX version #837

merged 1 commit into from
Feb 21, 2023

Conversation

annakhm
Copy link
Collaborator

@annakhm annakhm commented Feb 15, 2023

With latest NSX, search API result omits locale-service component, which data sources use in filtering.
This breaks vpn local endpoint data source when used with service_path. This change switches from search API to List API for such cases.
In addition, expose local_address in local enpoint data source.

@annakhm
Copy link
Collaborator Author

annakhm commented Feb 15, 2023

/test-all

With latest NSX, search API result omits locale-service
component, which data sources use in filtering.
This breaks vpn local endpoint data source when used with
service_path. This change switches from search API to List
API for such cases.
In addition, expose local_address in local enpoint data
source.

Signed-off-by: Anna Khmelnitsky <[email protected]>
Copy link
Collaborator

@ksamoray ksamoray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@annakhm annakhm merged commit 26c5a3e into master Feb 21, 2023
@annakhm annakhm deleted the vpn-data branch July 23, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants