Add FQDN or URL Custom support for context profile #835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksamoray
force-pushed
the
context_profile_custom_fqdns
branch
5 times, most recently
from
8c086d5 to
4821b83
Compare
annakhm
reviewed
Feb 2, 2023
| }, | ||
|
|
||
| Schema: map[string]*schema.Schema{ | ||
| "fqdn": { |
There was a problem hiding this comment.
Should we allow to configure CUSTOM_URL as part of same resource?
There was a problem hiding this comment.
Yeah we could rename this resource to "custom_attribute" and have both. Would it make this more usable?
ksamoray
force-pushed
the
context_profile_custom_fqdns
branch
2 times, most recently
from
d9bcff2 to
5ef1492
Compare
ksamoray
changed the title
ksamoray
force-pushed
the
context_profile_custom_fqdns
branch
2 times, most recently
from
a1a10d1 to
7a58332
Compare
ksamoray
force-pushed
the
context_profile_custom_fqdns
branch
4 times, most recently
from
e9f0567 to
4709d8e
Compare
annakhm
reviewed
Feb 16, 2023
| key := d.Get("key").(string) | ||
| attribute := d.Get("attribute").(string) | ||
| if d.Id() == "" { | ||
| d.SetId(makeCustomAttributeID(key, attribute)) |
There was a problem hiding this comment.
I believe we need to SetId at the end of Create, once we're the resource was created succesfully
ksamoray
force-pushed
the
context_profile_custom_fqdns
branch
from
4709d8e to
cdaf6e9
Compare
To allow addition of custom URLs or FQDNs to context profile objects. Signed-off-by: Kobi Samoray <[email protected]>
ksamoray
force-pushed
the
context_profile_custom_fqdns
branch
from
cdaf6e9 to
9a96959
Compare
|
/test-all |
1 similar comment
|
/test-all |
annakhm
approved these changes
Feb 23, 2023
Makes sense, I'll create an issue to track this follow up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To allow addition of custom URLs or FQDNs to context profile objects.
Fixes: #699, #721
Signed-off-by: Kobi Samoray [email protected]