Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support bridge confguration on segment #784

Merged
merged 1 commit into from
Sep 22, 2022
Merged

Support bridge confguration on segment #784

merged 1 commit into from
Sep 22, 2022

Conversation

annakhm
Copy link
Collaborator

@annakhm annakhm commented Aug 31, 2022

Add policy_bridge_profile data source and bridge_config clause
on segments.

Signed-off-by: Anna Khmelnitsky [email protected]

@annakhm
Copy link
Collaborator Author

annakhm commented Aug 31, 2022

/test-all

2 similar comments
@annakhm
Copy link
Collaborator Author

annakhm commented Aug 31, 2022

/test-all

@annakhm
Copy link
Collaborator Author

annakhm commented Aug 31, 2022

/test-all

@annakhm
Copy link
Collaborator Author

annakhm commented Aug 31, 2022

/test-all

@annakhm
Copy link
Collaborator Author

annakhm commented Aug 31, 2022

/test-all

1 similar comment
@annakhm
Copy link
Collaborator Author

annakhm commented Aug 31, 2022

/test-all

This was linked to issues Sep 1, 2022
Updating Segment clears Bridge configuration #483
Closed
Feature Request: Edge Bridge #678
Closed
ksamoray
ksamoray requested changes Sep 19, 2022
View reviewed changes
nsxt/segment_common.go Outdated
@@ -328,6 +350,12 @@ func getPolicyCommonSegmentSchema(vlanRequired bool, isFixed bool) map[string]*s
Default: model.Segment_REPLICATION_MODE_MTEP,
ValidateFunc: validation.StringInSlice(replicationModeValues, false),
},
"bridge_config": {
Type: schema.TypeList,
Description: "Beidge configuration",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bridge?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, fixed

@annakhm
Support bridge confguration on segment
e8bff0f 
Add policy_bridge_profile data source and bridge_config clause
on segments.

Signed-off-by: Anna Khmelnitsky <[email protected]>
@annakhm annakhm requested a review from ksamoray September 22, 2022 15:48
@annakhm annakhm merged commit 777fa7e into master Sep 22, 2022
@ajgrinnell
Copy link

Thank you for working on this. I seem to be getting errors still even with the latest provider. I have pieced together what I can from the code and think I have it, but its still not working. If you have any ideas I would appreciate it.

╷
│ Error: Unsupported block type
│
│ on segments.tf line 13, in resource "nsxt_policy_segment" "Overlay_Segment":
│ 13: bridge_config {
│
│ Blocks of type "bridge_config" are not expected here.
terraform plan -var-file="secret.tfvars"

│ Error: Invalid data source
│
│ on main.tf line 35, in data "nsxt_policy_bridge_profile" "TEST-Edge-Bridge":
│ 35: data "nsxt_policy_bridge_profile" "TEST-Edge-Bridge" {
│
│ The provider vmware/nsxt does not support data source "nsxt_policy_bridge_profile".

terraform version
Terraform v1.3.1
on linux_amd64

  • provider registry.terraform.io/vmware/nsxt v3.2.8

@annakhm
Copy link
Collaborator Author

annakhm commented Apr 27, 2023

Hi @ajgrinnell, sorry for late response, I've missed this comment. Bridge support was added with version 3.2.9

@annakhm annakhm deleted the segment-bridge branch February 5, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@2ez4szliu 2ez4szliu 2ez4szliu approved these changes

@ksamoray ksamoray Awaiting requested review from ksamoray

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature Request: Edge Bridge Updating Segment clears Bridge configuration
4 participants
@annakhm @ajgrinnell @ksamoray @2ez4szliu