Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix VM Not Found Issue in VM Tag #718

Merged
merged 1 commit into from
Mar 3, 2022
Merged

Conversation

enhaocui
Copy link
Contributor

Fix for issue #709. In such cases, provider should just swallow
the error, and print error messages.

@vmwclabot
Copy link
Member

@enhaocui, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@vmwclabot vmwclabot added the dco-required DCO Required label Feb 28, 2022
@enhaocui enhaocui requested a review from annakhm February 28, 2022 23:27
@enhaocui enhaocui force-pushed the ecui/fix_vmtag_vm_notfound branch from 7d13ab6 to bac1b8e Compare March 2, 2022 00:26
@vmwclabot vmwclabot removed the dco-required DCO Required label Mar 2, 2022
Fix for issue #709. In such cases, provider should just swallow
the error, and print error messages.

Signed-off-by: Enhao Cui <[email protected]>
@enhaocui enhaocui force-pushed the ecui/fix_vmtag_vm_notfound branch from bac1b8e to 5720d59 Compare March 2, 2022 00:32
@enhaocui enhaocui merged commit 0366efd into master Mar 3, 2022
@annakhm annakhm deleted the ecui/fix_vmtag_vm_notfound branch July 23, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants