Allow basic auth mode for VMC PCI use case #577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To allow basic authentication with VMC, this change is adding "Basic" vmc_auth_mode option. With this mode, in spite of no vmc token defined, provider will still detect VMC environment and avoid MP API for version management. The default for vmc_auth_mode is not changed here.
enhaocui
approved these changes
Feb 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To allow basic authentication with VMC, this change is adding "Basic"
vmc_auth_mode option. With this mode, in spite of no vmc token defined,
provider will still detect VMC environment and avoid MP API for version
management.
The default for vmc_auth_mode is not changed here.