Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support MAC address criteria in policy group #388

Merged
merged 2 commits into from
Jul 13, 2020
Merged

Support MAC address criteria in policy group #388

merged 2 commits into from
Jul 13, 2020

Conversation

annakhm
Copy link
Collaborator

@annakhm annakhm commented Jul 9, 2020

No description provided.

@annakhm annakhm requested review from asarfaty and enhaocui July 9, 2020 00:00
@ghost ghost added size/m Relative Sizing: medium documentation Documentation labels Jul 9, 2020
asarfaty
asarfaty reviewed Jul 12, 2020
View reviewed changes
nsxt/resource_nsxt_policy_group.go Outdated
@@ -201,6 +218,13 @@ func getCriteriaSetSchema() *schema.Resource {
Elem: getPathExpressionSchema(),
MaxItems: 1,
},
"macaddress_expression": {
Type: schema.TypeList,
Description: "An MAC address expression specifying MAC Address members in the Group",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A MAC instead of An MAC?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, done

@annakhm annakhm merged commit 7ebca3b into master Jul 13, 2020
@annakhm annakhm deleted the mac_address_in_group branch August 20, 2020 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asarfaty asarfaty asarfaty left review comments

@enhaocui enhaocui enhaocui approved these changes

Assignees
No one assigned
Labels
documentation Documentation size/m Relative Sizing: medium
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@annakhm @asarfaty @enhaocui