-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Federation rebase #358
Merged
Merged
Federation rebase #358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgrade to plugin sdk 1.12 and add nsxt-gm for federation development
This fails validity check with new plugin sdk.
Since global manager is only supported since 3.0.0, we can use common search mechanism to handle standard data sources.
Resource existance check function should be aware of whether the provider is a global manager.
and use search for GM test delete functions
Support for multiple locale services will be added later
…ource for acc test, add example usage in doc
Support multiple instances of locale services on tier0 resource for global manager. Tests will be added later, when edge cluster and edge node data sources are supported on global manager.
GetOkExists is only relevant for TypeBool, this change switches to correct type.
It would be easier to introduce global manager support with H-API since only one API call needs to be handled. H-API is more efficient even regardless GM support. In addition, fix revision check parameter in T0 Update.
Enable basic acc tests for gateways, GM-specific tests will follow.
Terrafor test does not respect gateway dependency on destroy. To work around this problem, detach the gateways before destroying. In addition, add printout on gateway delete to ease debugging (delete using H-API seems to be slow)
Resource acc tests will follow.
Fix some issues with gateway resources. In addition, allow fetching edge cluster by site only.
And fix gateway GM-LM related code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebase the federation branch in preparation for merge back