Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #317

Merged
merged 2 commits into from
May 20, 2020
Merged

Update dependencies #317

merged 2 commits into from
May 20, 2020

Conversation

annakhm
Copy link
Collaborator

@annakhm annakhm commented May 19, 2020

Upgrade to plugin sdk 1.12 and add nsxt-gm for federation development

Upgrade to plugin sdk 1.12 and add nsxt-gm for federation development
@annakhm annakhm requested review from asarfaty and enhaocui May 19, 2020 23:07
@ghost ghost added the size/xxl Relative Sizing: extra-extra-large label May 19, 2020
go.mod Outdated
github.com/vmware/go-vmware-nsxt v0.0.0-20191219213550-f4221331f638
github.com/vmware/vsphere-automation-sdk-go/lib v0.2.0
github.com/vmware/vsphere-automation-sdk-go/runtime v0.2.0
github.com/vmware/vsphere-automation-sdk-go/services/nsxt v0.3.0
github.com/vmware/vsphere-automation-sdk-go/services/nsxt-gm v0.1.0 // indirect
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dumb question: Why is nsxt-gm indirect here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing because we're not using it yet. We'll need to remove that.

Copy link
Contributor

@enhaocui enhaocui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

This fails validity check with new plugin sdk.
@annakhm annakhm merged commit c523486 into federation May 20, 2020
@annakhm annakhm deleted the upgrade_plugin_and_gm branch September 3, 2020 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/xxl Relative Sizing: extra-extra-large
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants