Add provider flag for a policy global manager env #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
annakhm
reviewed
May 19, 2020
nsxt/provider.go
Outdated
| @@ -145,6 +146,12 @@ func Provider() terraform.ResourceProvider { | |||
| Description: "Enforcement Point for NSXT Policy", | |||
| DefaultFunc: schema.EnvDefaultFunc("NSXT_POLICY_ENFORCEMENT_POINT", "default"), | |||
| }, | |||
| "policy_global_manager": { | |||
There was a problem hiding this comment.
I'd suggest to call it just "global_manager" - Madhu, what do you think?
There was a problem hiding this comment.
I agree, just "global_manager" is good.
enhaocui
reviewed
May 19, 2020
madhukark
reviewed
May 20, 2020
website/docs/index.html.markdown
Outdated
| host = "192.168.110.41" | ||
| username = "admin" | ||
| password = "default" | ||
| policy_global_manager = true |
madhukark
reviewed
May 20, 2020
website/docs/index.html.markdown
Outdated
| @@ -177,6 +189,8 @@ The following arguments are used to configure the VMware NSX-T Provider: | |||
| * `enforcement_point` - (Optional) Enforcement point, mostly relevant for policy | |||
| data sources. For VMC environment, this should be set to `vmc-enforcementpoint`. | |||
| For on-prem deployments, this setting should not be specified. | |||
| * `policy_global_manager` - (Optional) True if this is a policy global manager | |||
There was a problem hiding this comment.
Here too, just 'global_manager'. Also, can change the string 'policy global manager' to 'Global Manager'
annakhm
approved these changes
May 20, 2020
enhaocui
reviewed
May 20, 2020
website/docs/index.html.markdown
Outdated
| password = "default" | ||
| policy_global_manager = true | ||
| host = "192.168.110.41" | ||
| usernam = "admin" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.