Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize vm tag resources #261

Merged
merged 1 commit into from
Mar 11, 2020
Merged

Optimize vm tag resources #261

merged 1 commit into from
Mar 11, 2020

Conversation

annakhm
Copy link
Collaborator

@annakhm annakhm commented Mar 10, 2020

  • Make tags required in policy resource, since its the only
    attribute that can be set
  • Avoid update backend call if there is no change in corresponding
    configuration
  • Avoid update backend call in delete function if there were no
    tags to provider config

@annakhm
Optimize vm tag resources
7206c07 
* Make tags required in policy resource, since its the only
attribute that can be set
* Avoid update backend call if there is no change in corresponding
configuration
* Avoid update backend call in delete function if there were no
tags to provider config
@annakhm annakhm requested a review from asarfaty March 10, 2020 22:22
@ghost ghost added the size/m Relative Sizing: medium label Mar 10, 2020
@annakhm annakhm mentioned this pull request Mar 10, 2020
Closed
@annakhm annakhm merged commit 5ca795d into master Mar 11, 2020
@annakhm annakhm deleted the improve_vm_tags branch May 28, 2020 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asarfaty asarfaty asarfaty approved these changes

Assignees
No one assigned
Labels
size/m Relative Sizing: medium
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@annakhm @asarfaty