Pass IDs for the FW sections and rules for update #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
mkowalski
force-pushed
the
modify-firewall-in-place
branch
from
84d20ad to
0bf342f
Compare
Currently when updating a firewall rules internally they get deleted and the new ones are created (causing their IDs to change). This is not always a desired behaviour, as the NSX-T API itself allows changing the rules in place. This patch adds the current firewall section and rule ID to the payload in order to allow preserving the IDs.
mkowalski
force-pushed
the
modify-firewall-in-place
branch
from
0bf342f to
7cac13b
Compare
annakhm
approved these changes
Mar 14, 2019
asarfaty
approved these changes
Mar 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when updating a firewall rules internally they get
deleted and the new ones are created (causing their IDs to change).
This is not always a desired behaviour, as the NSX-T API itself
allows changing the rules in place.
This patch adds the current firewall section and rule ID to the
payload in order to allow preserving the IDs.