ImporterWrapper: Allocate a new Importer object (#1481) #1486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The wrapper function was updating the existing importer, but the replaced function ended up having the same pointer as the wrapper function, meaning that import would enter an infinite recursion loop. Tested by doing import, read, update, and delete for 1) nsxt_logical_tier1_router 2) nsxt_ip_pool Signed-off-by: Salvatore Orlando <[email protected]>
annakhm
reviewed
Dec 17, 2024
| @@ -66,15 +66,18 @@ func deleteWrapper(originalFunc schema.DeleteFunc, name string) schema.DeleteFun | |||
| } | |||
|
|
|||
| func importerWrapper(originalImporter *schema.ResourceImporter, name string) *schema.ResourceImporter { | |||
| newImporter := new(schema.ResourceImporter) | |||
There was a problem hiding this comment.
would it be more straightforward to return originalImporter here, and let the Read fail?
There was a problem hiding this comment.
that was the previous code.
Probably you meant do not wrapping the importer at all and let import fail at read?
annakhm
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The wrapper function was updating the existing importer, but the replaced function ended up having the same pointer as the wrapper function, meaning that import would enter an infinite recursion loop.
Tested by doing import, read, update, and delete for