Add nat type to nat rule resource #1480
Conversation
annakhm
force-pushed
the
add-nat-type
branch
2 times, most recently
from
494508f to
51dbc46
Compare
|
PASS: TestAccResourceNsxtPolicyNATRuleT1_natType (48.34s) |
annakhm
force-pushed
the
add-nat-type
branch
2 times, most recently
from
aee1f8b to
77d7615
Compare
| if err != nil { | ||
| return handleCreateError("NAT Rule", id, err) | ||
| } | ||
|
|
||
| d.SetId(id) | ||
| d.Set("nsx_id", id) | ||
| // In case nat type was not specified or got overridden by action | ||
| d.Set("type", natType) |
There was a problem hiding this comment.
Is this to restore any change that might have been done in line 311?
There was a problem hiding this comment.
No, this is create flow - if nat type was left blank by the user, we need to set the Computed nat type that was determined in line 372
annakhm
force-pushed
the
add-nat-type
branch
from
77d7615 to
ccb82f3
Compare
Before this change, only NAT64 and USER nat types were supported, and the value was calculated based on action. With this change, we need to keep in mind refresh of existing nat rule resources, hence the new type will be calculated. Signed-off-by: Anna Khmelnitsky <[email protected]>
annakhm
force-pushed
the
add-nat-type
branch
from
ccb82f3 to
11b6bfd
Compare
No description provided.