Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: replace deprecated plugin.Debug #1439

Merged
merged 1 commit into from
Oct 21, 2024
Merged

chore: replace deprecated plugin.Debug #1439

merged 1 commit into from
Oct 21, 2024

Conversation

tenthirtyam
Copy link
Collaborator

@tenthirtyam tenthirtyam commented Oct 17, 2024 •
edited
Loading

Summary of Pull Request

Replaces the deprecated plugin.Debug with the Debug field in ServeOpts.

Also simplifies debugMode.

Type of Pull Request

  • This is a bug fix.
  • This is an enhancement or feature.
  • This is a code style/formatting update.
  • This is a documentation update.
  • This is a refactoring update.
  • This is a chore update
  • This is something else.
    Please describe:

Related to Existing Issues

Test and Documentation Coverage

For bug fixes or features:

  • Tests have been completed.
  • Documentation has been added/updated.

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

@tenthirtyam
chore: replace deprecated plugin.Debug
793af67 
Replaces the deprecated `plugin.Debug` with the `Debug` fieldin `ServeOpts`.

Signed-off-by: Ryan Johnson <[email protected]>
@tenthirtyam tenthirtyam added provider Provider technical-debt Technical Debt chore Chore labels Oct 17, 2024
@tenthirtyam tenthirtyam self-assigned this Oct 17, 2024
@tenthirtyam tenthirtyam added size/xs Relative Sizing: extra-small needs-review Needs Review labels Oct 17, 2024
ksamoray
ksamoray approved these changes Oct 21, 2024
View reviewed changes
Copy link
Collaborator

@ksamoray ksamoray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

salv-orlando
salv-orlando approved these changes Oct 21, 2024
View reviewed changes
Copy link
Member

@salv-orlando salv-orlando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@salv-orlando salv-orlando merged commit dbf5369 into master Oct 21, 2024
3 checks passed
@salv-orlando salv-orlando deleted the chore/replace-deprecated-plugin.Debug branch October 21, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ksamoray ksamoray ksamoray approved these changes

@salv-orlando salv-orlando salv-orlando approved these changes

@annakhm annakhm Awaiting requested review from annakhm

Assignees

@tenthirtyam tenthirtyam

Labels
chore Chore needs-review Needs Review provider Provider size/xs Relative Sizing: extra-small technical-debt Technical Debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tenthirtyam @salv-orlando @ksamoray