Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: correct example in upgrade group #1432

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

ksamoray
Copy link
Collaborator

@ksamoray ksamoray commented Oct 15, 2024

Updates the syntax of the nsxt_upgrade_run resource where the data sources were placed within the run resource instead of above it.

Renames some of the display names within the example: predefined groups have a naming scheme which is set by NSX, and enhanced readability of hosts' data source display names.

@ksamoray ksamoray force-pushed the upgrade-docfix branch 3 times, most recently from c27e320 to fd9809f Compare October 15, 2024 14:22
@tenthirtyam tenthirtyam added the documentation Documentation label Oct 15, 2024
@ksamoray ksamoray force-pushed the upgrade-docfix branch 2 times, most recently from fe23696 to bc684d2 Compare October 15, 2024 14:43
@salv-orlando
Copy link
Member

@ksamoray Do you mind add a quick description of what you are changing in the doc in the commit message?
I know why you're doing it, but I will surely forget that in a few days!

Syntax of the nsxt_upgrade_run resource is broken - data sources were placed within the run resource instead of above it.
Also rename some of the display names within the example: predefined groups have a naming scheme which is set by NSX, and enhance readability of hosts' data source display names.

Signed-off-by: Kobi Samoray <[email protected]>
@tenthirtyam tenthirtyam changed the title Correct example in upgrade group documentation docs: correct example in upgrade group Nov 12, 2024
Copy link
Collaborator

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after the recent updates.

Updated the PR title to match conventional commit style.

@tenthirtyam tenthirtyam merged commit 04eeea9 into vmware:master Nov 12, 2024
3 checks passed
@ksamoray ksamoray deleted the upgrade-docfix branch November 20, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants