Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(gh): add codeql analysis #1424

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Conversation

tenthirtyam
Copy link
Collaborator

Summary of Pull Request

Adds CodeQL Analysis.

Type of Pull Request

  • This is a bug fix.
  • This is an enhancement or feature.
  • This is a code style/formatting update.
  • This is a documentation update.
  • This is a refactoring update.
  • This is a chore update
  • This is something else.
    Please describe:

Related to Existing Issues

Test and Documentation Coverage

For bug fixes or features:

  • Tests have been completed.
  • Documentation has been added/updated.

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

@tenthirtyam tenthirtyam added the chore Chore label Oct 12, 2024
@tenthirtyam tenthirtyam requested a review from annakhm October 12, 2024 03:36
@tenthirtyam tenthirtyam self-assigned this Oct 12, 2024
@tenthirtyam tenthirtyam force-pushed the chore(gh)/add-codeql-analysis branch 3 times, most recently from defcef0 to 77256e5 Compare October 12, 2024 03:48
@tenthirtyam tenthirtyam added needs-review Needs Review size/s Relative Sizing: small labels Oct 12, 2024
Adds CodeQL Analysis.

Signed-off-by: Ryan Johnson <[email protected]>
@tenthirtyam tenthirtyam force-pushed the chore(gh)/add-codeql-analysis branch from 77256e5 to 70b9956 Compare October 14, 2024 19:37
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@tenthirtyam tenthirtyam requested a review from a team October 21, 2024 12:18
@tenthirtyam
Copy link
Collaborator Author

@ksamoray @annakhm @salv-orlando - Could you review this item to enable the CodeQL scanning?

@tenthirtyam
Copy link
Collaborator Author

@vmware/terraform-provider-nsxt-maintainers: reminder.

Copy link
Member

@salv-orlando salv-orlando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@salv-orlando salv-orlando merged commit 35f6088 into master Dec 6, 2024
5 checks passed
@salv-orlando salv-orlando deleted the chore(gh)/add-codeql-analysis branch December 6, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Chore needs-review Needs Review size/s Relative Sizing: small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants