Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support vpc nat resource and its friends #1239

Closed
wants to merge 1 commit into from
Closed

Conversation

annakhm
Copy link
Collaborator

@annakhm annakhm commented Jun 26, 2024

No description provided.

@annakhm annakhm marked this pull request as draft June 26, 2024 03:36
@annakhm annakhm force-pushed the vpc-feature branch 3 times, most recently from 614c96a to 8460e5e Compare June 28, 2024 00:06
This PR offers support for:
1. vpc nat rule resource
2. vpc ip address allocation resource
   only addresses allocated from vpc subnet can be used
   as dest in nat rule
3. vpc nat data source
   this is helpful for specifying parent_path for nat rule

Signed-off-by: Anna Khmelnitsky <[email protected]>
@annakhm annakhm marked this pull request as ready for review June 28, 2024 01:58
@annakhm annakhm requested review from ksamoray and salv-orlando June 28, 2024 01:58
@annakhm
Copy link
Collaborator Author

annakhm commented Jun 28, 2024

Note that ip_address_allocation resource will be regenerated with new spec. Hence I didn't add detailed tests for it - basic testing is already covered by the nat resource test.

Update: resourceNsxtVpcIPAddressAllocationUpdate,
Delete: resourceNsxtVpcIPAddressAllocationDelete,
Importer: &schema.ResourceImporter{
State: nsxtPolicyPathResourceImporter,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: this will be changed to VPC-specific importer when regenerated

@annakhm annakhm marked this pull request as draft June 28, 2024 17:05
@annakhm
Copy link
Collaborator Author

annakhm commented Jul 3, 2024

Reposting the netto support for those objects with #1247

@annakhm annakhm closed this Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant