Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure project and VPC at provider level #1226

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

ksamoray
Copy link
Collaborator

@ksamoray ksamoray commented Jun 4, 2024

Allow configuration of the attributes above in the provider globally for the whole context, instead of the resource level.

Add VPC to context and handle it accordingly in tests and wrappers.

Signed-off-by: Kobi Samoray <[email protected]>
@ksamoray ksamoray force-pushed the vpc-config-provider branch from 398ba04 to cb6c1fe Compare June 4, 2024 12:42
@ksamoray
Copy link
Collaborator Author

ksamoray commented Jun 4, 2024

/test-all

@ksamoray ksamoray force-pushed the vpc-config-provider branch 2 times, most recently from 7faf9c1 to 335a5eb Compare June 4, 2024 12:57
Allow configuration of the attributes above in the provider globally for
the whole context, instead of the resource level.

Signed-off-by: Kobi Samoray <[email protected]>
@ksamoray ksamoray force-pushed the vpc-config-provider branch from 335a5eb to b2db212 Compare June 4, 2024 12:59
@ksamoray
Copy link
Collaborator Author

ksamoray commented Jun 4, 2024

/test-all

@ksamoray
Copy link
Collaborator Author

ksamoray commented Jun 6, 2024

I think that I should add some tests for this case as well.

@annakhm
Copy link
Collaborator

annakhm commented Jun 6, 2024

To avoid confusion, I suggest erroring out in case different vpcs are specified on provider level and in the resource

@ksamoray
Copy link
Collaborator Author

ksamoray commented Jun 9, 2024

/test-all

To handle invalid configuration of a context in both object and provider
levels.

Signed-off-by: Kobi Samoray <[email protected]>
@ksamoray ksamoray force-pushed the vpc-config-provider branch from 8b24632 to 1a0b9e0 Compare June 9, 2024 11:59
@ksamoray
Copy link
Collaborator Author

ksamoray commented Jun 9, 2024

/test-all

@vmwclabot
Copy link
Member

@ksamoray, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@vmwclabot vmwclabot added the dco-required DCO Required label Jun 10, 2024
Signed-off-by: Kobi Samoray <[email protected]>
@ksamoray ksamoray force-pushed the vpc-config-provider branch from 060577c to 131fb99 Compare June 10, 2024 12:55
@vmwclabot vmwclabot removed the dco-required DCO Required label Jun 10, 2024
Signed-off-by: Kobi Samoray <[email protected]>
@ksamoray ksamoray force-pushed the vpc-config-provider branch 7 times, most recently from 34f59eb to ddfeb34 Compare June 10, 2024 15:40
Signed-off-by: Kobi Samoray <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants