Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle invalid context errors #1224

Merged
merged 1 commit into from
Jun 11, 2024
Merged

Handle invalid context errors #1224

merged 1 commit into from
Jun 11, 2024

Conversation

ksamoray
Copy link
Collaborator

@ksamoray ksamoray commented Jun 3, 2024

When a resource or datasource is defined with an invalid context, e.g with a VPC for a resource with no VPC implementation, the provider crashes as the client creation is not validated.

This PR addresses this issue.

@ksamoray
Copy link
Collaborator Author

ksamoray commented Jun 3, 2024

/test-all

1 similar comment
@ksamoray
Copy link
Collaborator Author

ksamoray commented Jun 3, 2024

/test-all

Copy link
Member

@salv-orlando salv-orlando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

When a resource or datasource is defined with an invalid context, e.g
with a VPC for a resource with no VPC implementation, the provider
crashes as the client creation is not validated.

This PR addresses this issue.

Signed-off-by: Kobi Samoray <[email protected]>
@ksamoray ksamoray merged commit 01d1a37 into vmware:master Jun 11, 2024
3 checks passed
@ksamoray ksamoray deleted the null_client branch June 11, 2024 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants