API wrapper generator changes for VPC #1221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test-all |
|
/test-all |
ksamoray
force-pushed
the
vpc-api-gen
branch
2 times, most recently
from
c6bac15 to
6ea23e2
Compare
|
/test-all |
annakhm
reviewed
Jun 4, 2024
nsxt/utils.go
Outdated
| elemSchema["vpc_id"] = &schema.Schema{ | ||
| Type: schema.TypeString, | ||
| Description: "Id of the VPC which the resource belongs to.", | ||
| Optional: true, |
There was a problem hiding this comment.
For VPC-specific resources, vpc_id should be required, is that correct? Should this helper be able to return schema with required vpc_id?
Add VPC to context and handle it accordingly in tests and wrappers. Signed-off-by: Kobi Samoray <[email protected]>
|
/test-all |
salv-orlando
reviewed
Jun 6, 2024
| @@ -986,7 +989,6 @@ | |||
| - New | |||
| - Get | |||
| - Delete | |||
| - List | |||
There was a problem hiding this comment.
Was this removed intentionally or accidentally?
There was a problem hiding this comment.
This was specified twice within that object (line 992) - it's a bug. That failed the generator (probably added at some point by mistake without running the generator).
There was a problem hiding this comment.
Got it I did not see the duplicatin
salv-orlando
approved these changes
Jun 10, 2024
annakhm
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add VPC to context and handle it accordingly in tests and wrappers.