Add utility to parse standard policy path #1218
Conversation
| @@ -188,6 +188,55 @@ func getResourceIDFromResourcePath(rPath string, rType string) string { | |||
| return "" | |||
| } | |||
|
|
|||
| func parseStandardPolicyPath(path string) ([]string, error) { | |||
There was a problem hiding this comment.
Do you just need to collect the list of identifiers in the policy path, or will it also matter figuring out what is what?
For instance in:
/orgs/myorg/projects/myproj/infra/tier-1s/mygw1"
parent[2] is a router id
but in:
/orgs/myorg/projects/myproj/vpcs/myvpc/tier-1s/mygw1
parent[2] is a VPC id
There was a problem hiding this comment.
Parent list will be used as parameters for API calls, so in case of orgs/projects/vpc the ids will be used as parameters in API call in the same way as gw id or segment id would be used.
|
Can we utilize this (or share code with) in nsxtPolicyPathResourceImporterHelper? I've already added VPC support in PR #1217 |
annakhm
force-pushed
the
policy-path-parser
branch
from
b626744 to
66e3ed1
Compare
Good point, I think |
annakhm
force-pushed
the
policy-path-parser
branch
from
66e3ed1 to
a5473d2
Compare
|
|
||
| func TestParseStandardPolicyPath(t *testing.T) { | ||
|
|
||
| testData := []policyPathTest{ |
There was a problem hiding this comment.
nit: add negative test with invalid path and verify code fails as expected.
There was a problem hiding this comment.
There is a negative test below
| } | ||
| if infraPath { | ||
| // continue after infra marker | ||
| if segments[idx] != "infra" && segments[idx] != "global-infra" { |
There was a problem hiding this comment.
I don't remember a case where we can have global-infra for a project-scoped resource.
At the same time, I don't think that a special case to handle only "infra" when in org scope is mandatory
annakhm
force-pushed
the
policy-path-parser
branch
from
a5473d2 to
7a02a18
Compare
In addition, add helper to get or generate ID with parent path These helpers will be used in generated resources Signed-off-by: Anna Khmelnitsky <[email protected]>
annakhm
force-pushed
the
policy-path-parser
branch
from
7a02a18 to
fd8496b
Compare
This utility will be used in generated resources