Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape password when requesting for session token #1216

Merged
merged 1 commit into from
May 28, 2024

Conversation

annakhm
Copy link
Collaborator

@annakhm annakhm commented May 24, 2024

When NSX password contains certain special characters(such as &), those need to be encoded when sent to session/create API

@annakhm annakhm requested a review from ksamoray May 24, 2024 01:02
@annakhm
Copy link
Collaborator Author

annakhm commented May 24, 2024

/test-all

When NSX password contains certain special characters(such as &),
those need to be encoded when sent to session/create API

Signed-off-by: Anna Khmelnitsky <[email protected]>
@annakhm annakhm force-pushed the encode-session-create branch from 6386a79 to e408ced Compare May 24, 2024 01:45
Copy link
Member

@salv-orlando salv-orlando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@annakhm
Copy link
Collaborator Author

annakhm commented May 24, 2024

/test-all

@annakhm annakhm merged commit ef687b6 into master May 28, 2024
7 checks passed
@annakhm annakhm deleted the encode-session-create branch August 7, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants