Update syslog config spec in edge TN resource #1206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Port should follow the API spec and be defined as string rather than int. Spec allows port range, however NSX rejects multiple port config, so we'll leave the single port validation for now, while allowing to change it later without deprecating the attribute. In addition, this change removes name attribute for syslog since NSX seems to ignore it. Signed-off-by: Anna Khmelnitsky <[email protected]>
|
/test-all |
ksamoray
approved these changes
May 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port should follow the API spec and be defined as string rather than int. Spec allows port range, however NSX rejects multiple port config, so we'll leave the single port validation for now, while allowing to change it later without deprecating the attribute. In addition, this change removes name attribute for syslog since NSX seems to ignore it.