Change port validation to support both string and int types #1190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ksamoray, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
ksamoray
force-pushed
the
edge_port_check
branch
from
ef3ea2c to
e2a85a9
Compare
ksamoray
force-pushed
the
edge_port_check
branch
from
e2a85a9 to
2429a48
Compare
validateSinglePort() validates a string value and therefore unsuitable for use in this case. NSX will validate the port in any case. Fixes: vmware#1186 Signed-off-by: Kobi Samoray <[email protected]>
ksamoray
force-pushed
the
edge_port_check
branch
from
2429a48 to
0615ad5
Compare
ksamoray
changed the title
annakhm
approved these changes
Apr 25, 2024
|
/test-all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
validateSinglePort() validates a string value and therefore unsuitable for use in this case.
Validator is modified to allow usage also when port type is int.
Fixes: #1186