Change input of TNC realization from id to path #1181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since corresponding resource is policy resource, it makes more sense to use path and remove the need for site_path parameter, which is part of the path. In addition, make sure the error returned is never empty. Signed-off-by: Anna Khmelnitsky <[email protected]>
annakhm
force-pushed
the
tnc-realization-fix
branch
from
a427082 to
624d70a
Compare
|
/test-all |
qiyueyao
reviewed
Apr 12, 2024
nsxt/data_source_nsxt_policy_host_transport_node_collection_realization.go
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since corresponding resource is policy resource, it makes more sense to use path and remove the need for site_path parameter, which is part of the path.
In addition, make sure the error returned is never empty.