Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add policy sub cluster resource #1172

Merged
merged 2 commits into from
Apr 11, 2024
Merged

Add policy sub cluster resource #1172

merged 2 commits into from
Apr 11, 2024

Conversation

annakhm
Copy link
Collaborator

@annakhm annakhm commented Apr 3, 2024

No description provided.

@annakhm annakhm marked this pull request as draft April 3, 2024 01:07
@annakhm annakhm force-pushed the sub-cluster branch 2 times, most recently from d31c955 to 835f258 Compare April 3, 2024 04:00
@annakhm annakhm marked this pull request as ready for review April 3, 2024 04:20
@annakhm annakhm requested a review from ksamoray April 3, 2024 16:49
@annakhm
Copy link
Collaborator Author

annakhm commented Apr 3, 2024

/test-all

@annakhm annakhm requested a review from salv-orlando April 4, 2024 02:48
salv-orlando
salv-orlando reviewed Apr 5, 2024
View reviewed changes
nsxt/resource_nsxt_policy_sub_cluster.go Outdated
@@ -0,0 +1,256 @@
/* Copyright © 2020 VMware, Inc. All Rights Reserved.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: perhaps we should update the copyright year to 2024.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And change VMware to Broadcom?

@ksamoray
Copy link
Collaborator

ksamoray commented Apr 7, 2024

Code LGTM. Can we rename the resource to reflect that it's a compute sub-cluster? As from the name it can be anything

@salv-orlando salv-orlando added this to the v3.6.0 milestone Apr 9, 2024
@annakhm
Copy link
Collaborator Author

annakhm commented Apr 9, 2024

Code LGTM. Can we rename the resource to reflect that it's a compute sub-cluster? As from the name it can be anything

Renamed to compute_sub_cluster

@annakhm
Add policy sub cluster resource
2262a09 
Signed-off-by: Anna Khmelnitsky <[email protected]>
ksamoray
ksamoray approved these changes Apr 10, 2024
View reviewed changes
Copy link
Collaborator

@ksamoray ksamoray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@vmwclabot
Copy link
Member

@annakhm, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@vmwclabot vmwclabot added the dco-required DCO Required label Apr 10, 2024
@annakhm
Copy link
Collaborator Author

annakhm commented Apr 10, 2024

/test-all

@annakhm annakhm merged commit 4946ad7 into master Apr 11, 2024
7 checks passed
@annakhm annakhm deleted the sub-cluster branch August 2, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@salv-orlando salv-orlando salv-orlando left review comments

@ksamoray ksamoray ksamoray approved these changes

Assignees
No one assigned
Labels
dco-required DCO Required
Projects
None yet
Milestone
v3.6.0
Development

Successfully merging this pull request may close these issues.
4 participants
@annakhm @ksamoray @vmwclabot @salv-orlando