Handle password change in update #1117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NSX requires sending the old password while changing password. So the change uses the old password from the state, to verify that password change is legal. There is an API to reset password - it requires an admin permission and won't check old password. IMO it's better so as otherwise it would indicate that state is not in sync with NSX. Signed-off-by: Kobi Samoray <[email protected]>
|
/test-all |
1 similar comment
|
/test-all |
annakhm
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NSX requires sending the old password while changing password. So the change uses the old password from the state, to verify that password change is legal.
There is an API to reset password - it requires an admin permission and won't check old password. IMO it's better so as otherwise it would indicate that state is not in sync with NSX.