Make domain name unique to address test failures #1106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test-all |
annakhm
reviewed
Feb 13, 2024
| @@ -386,7 +386,7 @@ func TestAccResourceNsxtGlobalPolicyGatewayPolicy_withSite(t *testing.T) { | |||
| func TestAccResourceNsxtGlobalPolicyGatewayPolicy_withDomain(t *testing.T) { | |||
| name := "terraform-test" | |||
| siteName := getTestSiteName() | |||
| domainName := "new-domain" | |||
| domainName := fmt.Sprintf("new-domain-%d", getRandomSuffixInt()) | |||
There was a problem hiding this comment.
can we use getAccTestResourceName() for consistency with other tests?
There was a problem hiding this comment.
Sure, I thought that there's some reason that it wasn't used :)
Test fail occasionally due to delays in deletion of domains in global manager topologies. Signed-off-by: Kobi Samoray <[email protected]>
ksamoray
force-pushed
the
new_domain_id
branch
from
e4fd935 to
8de26d1
Compare
|
/test-all |
annakhm
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test fail occasionally due to delays in deletion of domains in global manager topologies.