Handle errors on manager_cluster resource properly #1103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test-all |
annakhm
reviewed
Feb 8, 2024
| @@ -356,7 +356,7 @@ func joinNodeToCluster(clusterID string, certSha256Thumbprint string, guestNode | |||
| } | |||
| _, err = client.Joincluster(joinClusterParams) | |||
| if err != nil { | |||
| return fmt.Errorf("Failed to join node to cluster: %s, node ip address: %s", err, guestNode.IPAddress) | |||
| return logAPIError(fmt.Sprintf("Failed to join node to cluster: %s, node ip address: %s", clusterID, guestNode.IPAddress), err) | |||
There was a problem hiding this comment.
Failed to join node test is repeated on Create (but not on Update), maybe lets remove the duplicate text from Create flow?
Output messages weren't outputed properly from provider. Signed-off-by: Kobi Samoray <[email protected]>
ksamoray
force-pushed
the
manager_cluster_err
branch
from
187f96c to
e3068cb
Compare
|
/test-all |
annakhm
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Output messages weren't outputed properly from provider.