Add discover node data source #1084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Add Discover Node data source. 2. Remove node_deployment_info from Host Transport Node. Considering we only support Host Transport Node create from vCenter server managing the ESXi type HostNode and in this case, discovered_node_id is required, so no need to provide node_deployment_info. Additionally, this could fix the issue that using node_deployment_info with VDS type host switch, which is the only host switch type supported, will receive error from NSX: ``` Failed to create HostTransportNode 9756979d-0165-4cc6-93dc-0c30bb6da065: VDS Configuration is specified for host 9756979d-0165-4cc6-93dc-0c30bb6da065 and its not managed by a vCenter. Please correct TransportNode configuration or connect the host to a VCenter. (code 9549) ``` Signed-off-by: graysonwu <[email protected]>
GraysonWu
force-pushed
the
add-discover-node
branch
from
6e0fe25 to
17a219e
Compare
annakhm
reviewed
Jan 19, 2024
| return fmt.Errorf("Error obtaining Discover Node external ID or IP address during read") | ||
| } else { | ||
| // Get by IP address | ||
| objList, err := discoverNodeClient.List(nil, nil, nil, nil, nil, nil, &ipAddress, nil, nil, nil, nil, nil, nil, nil) |
There was a problem hiding this comment.
I feel pagination might be required here for big deployments?
There was a problem hiding this comment.
Maybe I misunderstood something. Can multiple Nodes share the same IP address? I expect only one or none(NotFound) Node will be returned.
There was a problem hiding this comment.
My bad, I didn't realize the List has IP filter already in the call
annakhm
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Discover Node data source.
Remove node_deployment_info from Host Transport Node. Considering we only support Host Transport Node create from vCenter server managing the ESXi type HostNode and in this case, discovered_node_id is required, so no need to provide node_deployment_info.
Additionally, this could fix the issue that using node_deployment_info with VDS type host switch, which is the only host switch type supported, will receive error from NSX: