Fix connection initialization flow for joined node #1078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annakhm
force-pushed
the
connection-init-flow
branch
from
773a8ee to
9f358c2
Compare
|
/test-all |
ksamoray
reviewed
Jan 9, 2024
| @@ -168,7 +168,7 @@ func waitForNodeStatus(d *schema.ResourceData, m interface{}, nodes []NsxCluster | |||
| log.Printf("[DEBUG]: API probing for NSX is disabled") | |||
| return nil | |||
| } | |||
| connector := getPolicyConnectorForInit(m, false) | |||
| connector := getStandalonePolicyConnector(m, false) | |||
There was a problem hiding this comment.
I still see the same failure with the PR applied.
I've tried to change this line to
connector := getPolicyConnector(m)
Which worked - I think that as with getStandalonePolicyConnector we skip license assignment, this is where we want to assign the license and therefore use the regular getPolicyConnector
There was a problem hiding this comment.
This connection just waits for node status, it should not require license, but we don't want it to initialize the version for the main NSX connection and thus skip license assignment for it..
annakhm
force-pushed
the
connection-init-flow
branch
from
9f358c2 to
4b57dd4
Compare
When a connector is initialized for the sake of joining the manager cluster, the endpoint is different from main provider endpoint, thus global connection init flows such as NSX Version retrieval and licenses should not be triggered by such connection. Signed-off-by: Anna Khmelnitsky <[email protected]>
annakhm
force-pushed
the
connection-init-flow
branch
from
4b57dd4 to
ad7230e
Compare
|
/test-all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a connector is initialized for the sake of joining the manager cluster, the endpoint is different from main provider endpoint, thus global connection init flows such as NSX Version retrieval and licenses should not be triggered by such connection.