Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add upgradeGroup data source #1076

Merged
merged 2 commits into from
Feb 7, 2024
Merged

Conversation

GraysonWu
Copy link
Collaborator

No description provided.

@annakhm
Copy link
Collaborator

annakhm commented Jan 11, 2024

Do we know when the upgrade groups are created in NSX config? If they are not yet ready by the time data sources are evaluated, we need a special handing (at least not to fail config)

@GraysonWu GraysonWu force-pushed the upgrade-group branch 2 times, most recently from e41c21c to 791be57 Compare January 24, 2024 23:58
@GraysonWu
Copy link
Collaborator Author

Do we know when the upgrade groups are created in NSX config? If they are not yet ready by the time data sources are evaluated, we need a special handing (at least not to fail config)

Thanks. Good one. I didn't find any places mentioning this. I have added a polling func to avoid this issue.

@annakhm
Copy link
Collaborator

annakhm commented Jan 30, 2024

Do we know when the upgrade groups are created in NSX config? If they are not yet ready by the time data sources are evaluated, we need a special handing (at least not to fail config)

Thanks. Good one. I didn't find any places mentioning this. I have added a polling func to avoid this issue.

If the groups are not yet populated by NSX at the time config is evaluated, perhaps we better fail fast rather than wait (and also recommend making groups dependant on prepare resource, if that resources triggers group creation.
if we have established that prepare resource triggers groups creation, we may also consider making this dependency explicit by adding a fake attribute prepare_upgrade_id or something similar.

@GraysonWu GraysonWu requested a review from annakhm January 30, 2024 19:52
@GraysonWu
Copy link
Collaborator Author

Do we know when the upgrade groups are created in NSX config? If they are not yet ready by the time data sources are evaluated, we need a special handing (at least not to fail config)

Thanks. Good one. I didn't find any places mentioning this. I have added a polling func to avoid this issue.

If the groups are not yet populated by NSX at the time config is evaluated, perhaps we better fail fast rather than wait (and also recommend making groups dependant on prepare resource, if that resources triggers group creation. if we have established that prepare resource triggers groups creation, we may also consider making this dependency explicit by adding a fake attribute prepare_upgrade_id or something similar.

As I tested, upgrade groups will be created after a few seconds after the upgrade bundle upload starts.
Added the attribute for the sake of dependency and change the timeout to 1 min.

@salv-orlando salv-orlando added this to the v3.5.0 milestone Feb 5, 2024
Signed-off-by: graysonwu <[email protected]>
@GraysonWu GraysonWu merged commit 798e498 into vmware:master Feb 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants