Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI Fix] Specify display_name of LBAppProfile data source in test case #1068

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

2ez4szliu
Copy link
Contributor

In some test cases, we only specify the type for LbAppProfile data source when retrieving the default NSX LB app profile,
for example:

data "nsxt_policy_lb_app_profile" "default_http"{
  type = "HTTP"
}

this will fail if there are other test cases that run in parallel and create LB app profile of the same type.
We need to also specify display name for the default lb app profile when creating such data source

data "nsxt_policy_lb_app_profile" "default_http"{
  type = "HTTP"
  display_name = "default-http-lb-app-profile"
}

@2ez4szliu
Copy link
Contributor Author

/test-all

1 similar comment
@ksamoray
Copy link
Collaborator

/test-all

Copy link
Collaborator

@ksamoray ksamoray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding some random element into the display name will reduce the risk of collision when there are some leftovers from tests which failed before.
But for now I think it's good as it is.

@2ez4szliu 2ez4szliu merged commit 2ed3221 into vmware:master Dec 18, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants