Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revise transport_node and host_transport_node #1067

Merged
merged 1 commit into from
Jan 3, 2024
Merged

Revise transport_node and host_transport_node #1067

merged 1 commit into from
Jan 3, 2024

Conversation

ksamoray
Copy link
Collaborator

As nsxt_policy_transport_node covers host-node, the resource above is required to cover only edge-nodes.
Therefore the resource is renamed and non-edge attributes are removed.

Also remove redundant attributes from policy_host_transport_node resource.

@ksamoray ksamoray force-pushed the edge_transport_node branch from 22f676c to 10ea8e1 Compare December 14, 2023 10:07
@ksamoray
Copy link
Collaborator Author

/test-all

@ksamoray ksamoray force-pushed the edge_transport_node branch from 10ea8e1 to 2f30935 Compare December 14, 2023 11:53
@ksamoray
Copy link
Collaborator Author

/test-all

@ksamoray ksamoray changed the title Revise transport_node host_transport_node Revise transport_node and host_transport_node Dec 14, 2023
@ksamoray ksamoray force-pushed the edge_transport_node branch from 2f30935 to a43f0fd Compare December 18, 2023 18:35
@annakhm
Copy link
Collaborator

annakhm commented Dec 18, 2023

Do we want to change transport_zone_profile to transport_zone_profiles as part of this PR as well, to avoid confusion on formatting this attribute (as a list rather than string)?

@ksamoray ksamoray force-pushed the edge_transport_node branch from a43f0fd to a8b5286 Compare December 19, 2023 07:38
@ksamoray
Revise transport_node host_transport_node
5d5289d 
As nsxt_policy_transport_node covers host-node, the resource above is
required to cover only edge-nodes.
Therefore the resource is renamed and non-edge attributes are removed.

Also remove redundant attributes from policy_host_transport_node
resource.

Signed-off-by: Kobi Samoray <[email protected]>
@ksamoray ksamoray force-pushed the edge_transport_node branch from a8b5286 to 5d5289d Compare December 19, 2023 07:57
@ksamoray
Copy link
Collaborator Author

/test-all

@ksamoray ksamoray merged commit c236d7a into vmware:master Jan 3, 2024
5 checks passed
@ksamoray ksamoray deleted the edge_transport_node branch January 3, 2024 10:38
@martinrohrbach
Copy link
Contributor

@ksamoray @annakhm
We just started testing deployment of edges using the nsxt_transport_node resource and stumbled over the fact that the currently released provider doesn't allow for multiple "standard_host_switch" entries. This PR should fix this ... so ... would you by any chance know when the next release of the provider is planned? :)

(I thought it's easier to comment here rather than openening an issue, after all it's a beta resource as well, hope that is ok)

@ksamoray
Copy link
Collaborator Author

ksamoray commented Jan 8, 2024

@ksamoray @annakhm We just started testing deployment of edges using the nsxt_transport_node resource and stumbled over the fact that the currently released provider doesn't allow for multiple "standard_host_switch" entries. This PR should fix this ... so ... would you by any chance know when the next release of the provider is planned? :)

(I thought it's easier to comment here rather than openening an issue, after all it's a beta resource as well, hope that is ok)

Hi @martinrohrbach, the release schedule is published here:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annakhm annakhm annakhm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ksamoray @annakhm @martinrohrbach