Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support of overwriting role binding of local user #1063

Merged
merged 3 commits into from
Dec 18, 2023

Conversation

wsquan171
Copy link
Contributor

This PR addsoverwrite_local_user to role binding resource. When set to true, allows Create and Delete of role bindings of local users. On create, existing role bindings which comes with local user creation will be overwritten per terraform definition. On delete, the role binding will be reverted back to auditor only.

Also refactors roles_for_path as a set instead of list. This affects both principle identity and role binding resource, but no further doc change is needed.

Added build-in roles on NSX to doc for easier referenced. Linked NSX doc for actual permission matrix.

@wsquan171
Copy link
Contributor Author

/test-all

@ksamoray
Copy link
Collaborator

Hi, I've tested the role part, it works :)
Can you also while you're at this, change password_reset_required to Optional: true?
API allows updating of this attribute but the resource defines it as computed only.

@wsquan171
Copy link
Contributor Author

Hi, I've tested the role part, it works :) Can you also while you're at this, change password_reset_required to Optional: true? API allows updating of this attribute but the resource defines it as computed only.

password_reset_required is actually a read only attr, determined based on last password change and password policy. You can try PUT updating the field, it won't take any effect.

@ksamoray
Copy link
Collaborator

Indeed it seems like my problem is different: API doc states that for password_change_frequency:
"This can be set to 0 to indicate no password change is required"
But instead it requires a password change for every login. I'll open a bug for this.
As for password_reset_required - doc says it's writable (and it didn't error when I set it with curl). However I don't see any impact, so let's leave it as is for now.

@wsquan171 wsquan171 merged commit 6033a1d into vmware:master Dec 18, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants