Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement policy_lb_client_ssl_profile resource #1028

Merged
merged 1 commit into from
Nov 30, 2023
Merged

Implement policy_lb_client_ssl_profile resource #1028

merged 1 commit into from
Nov 30, 2023

Conversation

2ez4szliu
Copy link
Contributor

@2ez4szliu 2ez4szliu commented Nov 10, 2023 •
edited
Loading

Implement nsxt_policy_lb_client_ssl_profile resource

@2ez4szliu 2ez4szliu linked an issue Nov 13, 2023 that may be closed by this pull request
Add resource for nsxt_policy_lb_client_ssl_profile #719
Closed
@2ez4szliu 2ez4szliu force-pushed the lb-ssl-client branch 2 times, most recently from 2c187b9 to 7af8ebb Compare November 14, 2023 00:36
@2ez4szliu
Copy link
Contributor Author

/test-all

@2ez4szliu 2ez4szliu changed the title Impelemnt policy_lb_client_ssl_profile resource Implemnt policy_lb_client_ssl_profile resource Nov 14, 2023
@2ez4szliu 2ez4szliu changed the title Implemnt policy_lb_client_ssl_profile resource Implement policy_lb_client_ssl_profile resource Nov 14, 2023
annakhm
annakhm reviewed Nov 14, 2023
View reviewed changes
nsxt/resource_nsxt_policy_lb_client_ssl_profile.go
"description": getDescriptionSchema(),
"revision": getRevisionSchema(),
"tag": getTagsSchema(),
"cipher_group_label": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds from the description this should be Computed only?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this value can be configured, it is the name/label for the ciphers groups, ciphers will be computed based on the value of cipher_group_label

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The doc says below A label of cipher group which is mostly consumed by GUI. The server will populate this field when returing the resource. So one of those seems incorrect - either the doc, or the code

Copy link
Contributor Author

@2ez4szliu 2ez4szliu Nov 20, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the doc is incorrect, it's fixed now.

The server will populate this field when returing the resource. Ignored on PUT and POST.

These are comments for the Links field in the model package, not sure why it ended up in the cipher_group_label after auto-generating the doc. Thanks for catching this

@2ez4szliu
Copy link
Contributor Author

/test-all

annakhm
annakhm approved these changes Nov 30, 2023
View reviewed changes
Copy link
Collaborator

@annakhm annakhm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@2ez4szliu 2ez4szliu merged commit cff2a7f into vmware:master Nov 30, 2023
5 checks passed
@2ez4szliu 2ez4szliu deleted the lb-ssl-client branch November 30, 2023 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annakhm annakhm annakhm approved these changes

@ksamoray ksamoray Awaiting requested review from ksamoray

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add resource for nsxt_policy_lb_client_ssl_profile
2 participants
@2ez4szliu @annakhm