Fix release header template #1004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the following changes w.r.t. release action: - Replaces --rm-dist with --clean See: https://goreleaser.com/deprecations/#-rm-dist - Bumps goreleaser-action version - Sets action permission Signed-off-by: Shawn Wang <[email protected]>
Signed-off-by: Shawn Wang <[email protected]>
Using a newer version to get rid of deprecation notice for save-state and set-output warnings in the v2 release. Signed-off-by: Shawn Wang <[email protected]>
|
/test-all |
|
Thanks, releaser changes LGTM, but what is the motivation for changing regex quotes? |
@annakhm the release workflow's golang lint ci reports:
which is not reported by our PR job. Not sure if it's a version difference of the action or a configuration difference. For reference an earlier run failed with: https://github.com/wsquan171/terraform-provider-nsxt/actions/runs/6567259777 |
annakhm
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to fix the broken release note header rendering since v3.2.0, due to the command line option in
goreleaserchanged from--release-headerto--release-header-tmpl, where the prior one is now treated as a static file.Also addresses the following nits in our release action:
ghaction-import-gpgaction to latest to address deprecation warnings ofsave-stateandset-output--cleaninstead of--rm-distper https://goreleaser.com/deprecations/#-rm-distTakes care of regex quoting of several instances as previously not being captured by PR golang lint jobs.
Testing done: