Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add workload vcenter check #90

Merged

Conversation

burnsjared0415
Copy link
Contributor

@burnsjared0415 burnsjared0415 commented Feb 12, 2024

Summary

Added a workload domain vCenter Server check to PowerManagement-ManagmentDomain.ps1 so that we ask if user wants to move forward if workload domain vCenter Server instances are still powered on.

Type

  • Bugfix
  • Enhancement or Feature
  • Code Style or Formatting
  • Documentation
  • Refactoring
  • Chore
  • Other
    Please describe:

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

Test and Documentation

  • Tests have been completed.
  • Documentation has been added or updated.

Issue References

Closes #46

Additional Information

@github-actions github-actions bot added documentation Documentation needs-review Needs Review labels Feb 12, 2024
@burnsjared0415 burnsjared0415 marked this pull request as ready for review February 12, 2024 18:39
@burnsjared0415 burnsjared0415 requested a review from a team as a code owner February 12, 2024 18:39
@tenthirtyam tenthirtyam changed the title feat: added Workload vCenter check feat: add workload vcenter check Feb 12, 2024
@tenthirtyam tenthirtyam self-requested a review February 12, 2024 19:08
@tenthirtyam tenthirtyam added this to the v1.4.1 milestone Feb 12, 2024
@tenthirtyam tenthirtyam force-pushed the feat-add-workload-vc-check branch 3 times, most recently from edaafdf to 5ab3aa6 Compare February 12, 2024 19:19
Added a workload domain vCenter Server check to `PowerManagement-ManagmentDomain.ps1` so that we ask if user wants to move forward if workload domain vCenter Server instances are still powered on.

Ref: vmware#46

Signed-off-by: Jared Burns <[email protected]>
@tenthirtyam tenthirtyam force-pushed the feat-add-workload-vc-check branch from 5ab3aa6 to a1f1ccb Compare February 12, 2024 19:31
Copy link
Collaborator

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tenthirtyam tenthirtyam removed the needs-review Needs Review label Feb 12, 2024
@tenthirtyam tenthirtyam merged commit 43ad68b into vmware:develop Feb 12, 2024
1 check passed
Copy link

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 14, 2024
@tenthirtyam tenthirtyam modified the milestones: v1.4.1, v1.4.2 Jul 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for a warning and confirmation for management domain shutdown if any workload domain is powered on
2 participants