Skip to content

Commit

Permalink
Properly check authorization on incoming guestOps requests.
Browse files Browse the repository at this point in the history
Fix public pipe request checks.  Only a SessionRequest type should
be accepted on the public pipe.
  • Loading branch information
johnwvmw committed Aug 21, 2022
1 parent 08cac55 commit 70a7475
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion open-vm-tools/vgauth/serviceImpl/proto.c
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*********************************************************
* Copyright (C) 2011-2016,2019-2021 VMware, Inc. All rights reserved.
* Copyright (C) 2011-2016,2019-2022 VMware, Inc. All rights reserved.
*
* This program is free software; you can redistribute it and/or modify it
* under the terms of the GNU Lesser General Public License as published
Expand Down Expand Up @@ -1201,6 +1201,10 @@ Proto_SecurityCheckRequest(ServiceConnection *conn,
VGAuthError err;
gboolean isSecure = ServiceNetworkIsConnectionPrivateSuperUser(conn);

if (conn->isPublic && req->reqType != PROTO_REQUEST_SESSION_REQ) {
return VGAUTH_E_PERMISSION_DENIED;
}

switch (req->reqType) {
/*
* This comes over the public connection; alwsys let it through.
Expand Down

0 comments on commit 70a7475

Please sign in to comment.